Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update registry.access.redhat.com/ubi9/ubi-minimal docker tag to v9.5-1733767867 #227

Conversation

red-hat-konflux[bot]
Copy link

@red-hat-konflux red-hat-konflux bot commented Nov 12, 2024

This PR contains the following updates:

Package Type Update Change
registry.access.redhat.com/ubi9/ubi-minimal final minor 9.4 -> 9.5-1733767867

Configuration

📅 Schedule: Branch creation - "after 5am on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

This PR has been generated by MintMaker (powered by Renovate Bot).

@openshift-ci openshift-ci bot requested review from dtrifiro and rpancham November 12, 2024 14:07
Copy link

openshift-ci bot commented Nov 12, 2024

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/registry.access.redhat.com-ubi9-ubi-minimal-9.x branch from 78ddecd to aebdf03 Compare December 9, 2024 08:06
@red-hat-konflux red-hat-konflux bot changed the title chore(deps): update registry.access.redhat.com/ubi9/ubi-minimal docker tag to v9.5 chore(deps): update registry.access.redhat.com/ubi9/ubi-minimal docker tag to v9.5-1731604394 Dec 9, 2024
@red-hat-konflux red-hat-konflux bot changed the title chore(deps): update registry.access.redhat.com/ubi9/ubi-minimal docker tag to v9.5-1731604394 chore(deps): update registry.access.redhat.com/ubi9/ubi-minimal docker tag to v9.5-1733767867 Dec 9, 2024
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/registry.access.redhat.com-ubi9-ubi-minimal-9.x branch from aebdf03 to c33daa6 Compare December 9, 2024 20:06
Copy link

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: red-hat-konflux[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dtrifiro
Copy link

dtrifiro commented Dec 10, 2024

As part of this, we'll have to bump the ROCm version to 6.3 as well, as the rhel/9.5 builds are not available for 6.2.3:

https://repo.radeon.com/amdgpu/6.2.3/rhel/9.5-1733767867/main/x86_64/repodata/repomd.xml

edit: although we can bump from 6.2.3 to 6.3, torch does not publish ROCm 6.3 builds just yet.

Copy link

openshift-ci bot commented Dec 18, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Dec 18, 2024
@dtrifiro
Copy link

I ended up reverting the change for the ROCm dockerfile, waiting for torch nightlies for 6.3

cc @heyselbi

Copy link
Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

openshift-ci bot commented Dec 18, 2024

@red-hat-konflux[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smoke-test 0a7392c link true /test smoke-test
ci/prow/images 0a7392c link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

red-hat-konflux bot and others added 2 commits December 19, 2024 13:00
…r tag to v9.5-1733767867

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
amdgpu builds for 9.5 are not published yet for ROCm 6.2.3, we can't
bump ROCm to 6.3 either because torch nightlies for 6.3 aren't out yet.
@dtrifiro dtrifiro force-pushed the konflux/mintmaker/main/registry.access.redhat.com-ubi9-ubi-minimal-9.x branch from 0a7392c to 31fcf13 Compare December 19, 2024 12:00
@dtrifiro dtrifiro merged commit 0d9d134 into main Dec 19, 2024
1 of 5 checks passed
@dtrifiro dtrifiro deleted the konflux/mintmaker/main/registry.access.redhat.com-ubi9-ubi-minimal-9.x branch December 19, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant