Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook Proxy maintenance #1298

Merged
merged 12 commits into from
Sep 2, 2024
Merged

Webhook Proxy maintenance #1298

merged 12 commits into from
Sep 2, 2024

Conversation

BraisVQ
Copy link
Contributor

@BraisVQ BraisVQ commented Aug 21, 2024

  • Update to Golang 1.23

  • Set availability checks only in the forward event as it is executed twice in normal usage (they are triggered when a pipeline is created, updated or removed already)

  • Adjust Webhook Proxy resources to match the real usage metrics in an effort to optimize Cluster resources.

CPU Request CPU Limit Mem Request Mem Limit
Before 50m 200m 128Mi 128Mi
After 25m 50m 30Mi 40Mi

24-hour metrics from an active project:

image

@BraisVQ BraisVQ marked this pull request as ready for review August 30, 2024 13:17
gerardcl
gerardcl previously approved these changes Aug 31, 2024
Copy link
Member

@gerardcl gerardcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
See suggestion, is it ok?

jenkins/webhook-proxy/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: gerardcl <gerard.castillo@boehringer-ingelheim.com>
@BraisVQ BraisVQ merged commit 5d819ee into master Sep 2, 2024
24 checks passed
@BraisVQ BraisVQ deleted the feature/webhook-proxy-maintenance branch September 2, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants