Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins maintenance #1299

Merged
merged 29 commits into from
Sep 2, 2024
Merged

Jenkins maintenance #1299

merged 29 commits into from
Sep 2, 2024

Conversation

BraisVQ
Copy link
Contributor

@BraisVQ BraisVQ commented Aug 22, 2024 •
edited
Loading

Test:

@BraisVQ BraisVQ mentioned this pull request Aug 22, 2024
Closed
@BraisVQ BraisVQ mentioned this pull request Aug 27, 2024
Closed
@BraisVQ BraisVQ mentioned this pull request Aug 29, 2024
Merged
5 tasks
@BraisVQ BraisVQ marked this pull request as ready for review August 30, 2024 13:19
@BraisVQ BraisVQ mentioned this pull request Aug 30, 2024
Merged
gerardcl
gerardcl previously approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@gerardcl gerardcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Nevertheless, see missing end file line break suggestion!

jenkins/agent-base/ensure_java_jre_is_adequate.sh Outdated Show resolved Hide resolved
@BraisVQ @gerardcl
add end line
ce11838 
Co-authored-by: gerardcl <gerard.castillo@boehringer-ingelheim.com>
@BraisVQ BraisVQ merged commit de64651 into master Sep 2, 2024
24 checks passed
@BraisVQ BraisVQ deleted the feature/jenkins-maintenance branch September 2, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardcl gerardcl gerardcl approved these changes

@michaelsauter michaelsauter Awaiting requested review from michaelsauter michaelsauter is a code owner

@oalyman oalyman Awaiting requested review from oalyman oalyman is a code owner

@jorge-romero jorge-romero Awaiting requested review from jorge-romero

@jafarre-bi jafarre-bi Awaiting requested review from jafarre-bi

@hrcornejo hrcornejo Awaiting requested review from hrcornejo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Java version in Jenkins server and agent
2 participants
@BraisVQ @gerardcl