fix(nyz): fix logger assertion and unittest bug

opendilab · Mar 21, 2023 · 405191d · 405191d
1 parent 503d273
commit 405191d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/ding/framework/middleware/functional/logger.py b/ding/framework/middleware/functional/logger.py
@@ -171,7 +171,8 @@ def wandb_online_logger(
     else:
         if not isinstance(cfg, EasyDict):
             cfg = EasyDict(cfg)
-        assert tuple(cfg.keys()) == ("gradient_logger", "plot_logger", "video_logger", "action_logger", "return_logger")
+        assert set(cfg.keys()
+                   ) == set(["gradient_logger", "plot_logger", "video_logger", "action_logger", "return_logger"])
         assert all(value in [True, False] for value in cfg.values())
 
     # The visualizer is called to save the replay of the simulation

diff --git a/ding/framework/middleware/tests/test_logger.py b/ding/framework/middleware/tests/test_logger.py
@@ -197,7 +197,7 @@ def test_wandb_online_logger():
         dict(
             gradient_logger=True,
             plot_logger=True,
-            action_logger='action probability',
+            action_logger=True,
             return_logger=True,
             video_logger=True,
         )
@@ -251,7 +251,7 @@ def test_wandb_online_logger_gradient():
 @pytest.mark.tmp
 def test_wandb_offline_logger(mocker):
     record_path = './video_pendulum_cql'
-    cfg = EasyDict(dict(gradient_logger=True, plot_logger=True, action_logger='action probability', vis_dataset=True))
+    cfg = EasyDict(dict(gradient_logger=True, plot_logger=True, action_logger=True, vis_dataset=True))
     env = TheEnvClass()
     ctx = OnlineRLContext()
     ctx.train_output = [{'reward': 1, 'q_value': [1.0]}]