Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pu): fix dqfd compatibility #161

Merged
merged 4 commits into from
Dec 22, 2021
Merged

Conversation

puyuan1996
Copy link
Collaborator

Description

fix dqfd compatibility with new dqfd_nstep_td_error function

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #161 (2989564) into main (ad71feb) will decrease coverage by 0.17%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   84.94%   84.76%   -0.18%     
==========================================
  Files         427      427              
  Lines       32797    32461     -336     
==========================================
- Hits        27859    27516     -343     
- Misses       4938     4945       +7     
Flag Coverage Δ
unittests 84.76% <25.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/policy/r2d3.py 15.10% <0.00%> (-0.24%) ⬇️
ding/rl_utils/td.py 77.83% <ø> (ø)
ding/policy/dqfd.py 96.66% <100.00%> (ø)
ding/rl_utils/tests/test_td.py 100.00% <100.00%> (ø)
ding/entry/tests/test_parallel_entry.py 45.45% <0.00%> (-4.55%) ⬇️
ding/entry/tests/test_serial_entry_onpolicy.py 78.37% <0.00%> (-2.11%) ⬇️
ding/utils/tests/test_system_helper.py 80.00% <0.00%> (-1.82%) ⬇️
ding/rl_utils/tests/test_gae.py 61.90% <0.00%> (-1.74%) ⬇️
...s/env_manager/tests/test_subprocess_env_manager.py 97.74% <0.00%> (-1.71%) ⬇️
ding/model/template/tests/test_mbpo.py 76.66% <0.00%> (-1.46%) ⬇️
... and 144 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad71feb...2989564. Read the comment docs.

@PaParaZz1 PaParaZz1 added the bug Something isn't working label Dec 22, 2021
@PaParaZz1 PaParaZz1 merged commit 1040c9f into opendilab:main Dec 22, 2021
@puyuan1996 puyuan1996 deleted the polish-r2d3 branch January 7, 2022 07:00
puyuan1996 added a commit to puyuan1996/DI-engine that referenced this pull request Apr 18, 2022
* polish(pu): polish r2d3

* polish(pu): first abs then sum each item in td-error

* fix(pu): fix dqfd compatibility
SolenoidWGT added a commit to SolenoidWGT/DI-engine that referenced this pull request Aug 22, 2023
* use fp16 in instruction (opendilab#80)

* delete torch_dtype of README's example code (opendilab#100)

* feat(ckpt): support async ckpt upload and ckpt snapshot

---------

Co-authored-by: WRH <12756472+wangruohui@users.noreply.github.com>
Co-authored-by: x54-729 <45304952+x54-729@users.noreply.github.com>
Co-authored-by: wangguoteng.p <wangguoteng925@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants