Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(zlx): support async reset for envpool env manager #250

Merged
merged 5 commits into from
Jun 16, 2022

Conversation

LuciusMos
Copy link
Collaborator

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #250 (e25e849) into main (6512855) will increase coverage by 0.08%.
The diff coverage is 10.52%.

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   85.84%   85.93%   +0.08%     
==========================================
  Files         476      496      +20     
  Lines       36535    39410    +2875     
==========================================
+ Hits        31364    33867    +2503     
- Misses       5171     5543     +372     
Flag Coverage Δ
unittests 85.93% <10.52%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/envs/env_manager/envpool_env_manager.py 37.34% <6.25%> (-3.75%) ⬇️
...envs/env_manager/tests/test_envpool_env_manager.py 38.46% <33.33%> (+2.74%) ⬆️
ding/framework/message_queue/redis.py 64.28% <0.00%> (-19.05%) ⬇️
ding/framework/message_queue/tests/test_redis.py 84.84% <0.00%> (-15.16%) ⬇️
ding/entry/utils.py 88.23% <0.00%> (-11.77%) ⬇️
ding/policy/policy_factory.py 84.61% <0.00%> (-10.13%) ⬇️
ding/envs/env_manager/tests/test_shm.py 96.15% <0.00%> (-3.85%) ⬇️
ding/framework/event_loop.py 92.98% <0.00%> (-3.51%) ⬇️
ding/reward_model/base_reward_model.py 79.66% <0.00%> (-3.20%) ⬇️
ding/entry/serial_entry_gail.py 18.00% <0.00%> (-2.00%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6512855...e25e849. Read the comment docs.

@PaParaZz1 PaParaZz1 added efficiency optimization Efficiency optimization (time, memory and so on) env Questions about RL environment labels Mar 31, 2022
@LuciusMos LuciusMos force-pushed the dev-envpool-envmanager-async branch from 7de0277 to 9226170 Compare April 1, 2022 06:03
@PaParaZz1 PaParaZz1 changed the title feature(zlx): Support async reset for envpool env manager feature(zlx): support async reset for envpool env manager Apr 1, 2022
@LuciusMos LuciusMos force-pushed the dev-envpool-envmanager-async branch from 13d8b57 to e25e849 Compare April 21, 2022 08:23
@PaParaZz1 PaParaZz1 merged commit 0246f05 into main Jun 16, 2022
@PaParaZz1 PaParaZz1 deleted the dev-envpool-envmanager-async branch June 16, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efficiency optimization Efficiency optimization (time, memory and so on) env Questions about RL environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants