Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zym): modify default setting in mujoco #35

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

YinminZhang
Copy link
Contributor

  1. fix some typos in warp_mujoco
  2. modify default setting in warp_mujoco

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #35 (0b68943) into main (42e31ea) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   89.69%   89.89%   +0.20%     
==========================================
  Files         339      337       -2     
  Lines       24754    24641     -113     
==========================================
- Hits        22202    22151      -51     
+ Misses       2552     2490      -62     
Flag Coverage Δ
unittests 89.89% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/envs/env_manager/subprocess_env_manager.py 82.21% <0.00%> (-0.25%) ⬇️
ding/policy/impala.py 83.06% <0.00%> (ø)
ding/entry/cli.py
ding/entry/predefined_config.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e31ea...0b68943. Read the comment docs.

@PaParaZz1 PaParaZz1 changed the title style(zym): modify default setting in mujoco fix(zym): modify default setting in mujoco Aug 27, 2021
@PaParaZz1 PaParaZz1 added bug Something isn't working env Questions about RL environment labels Aug 27, 2021
@@ -1,10 +1,12 @@
from typing import Dict
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can be merged

@PaParaZz1 PaParaZz1 merged commit 6326529 into opendilab:main Aug 27, 2021
puyuan1996 pushed a commit to puyuan1996/DI-engine that referenced this pull request Dec 14, 2021
puyuan1996 pushed a commit to puyuan1996/DI-engine that referenced this pull request Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working env Questions about RL environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants