Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xjx): discard message sent by self in redis mq #354

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Conversation

sailxjx
Copy link
Member

@sailxjx sailxjx commented Jun 7, 2022

Description

In the original code, a message sent by itself may also be received by itself, which may cause an exception at the receiving end.

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #354 (e98ea53) into main (72c1005) will decrease coverage by 0.85%.
The diff coverage is 56.66%.

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   86.75%   85.89%   -0.86%     
==========================================
  Files         513      524      +11     
  Lines       39464    41591    +2127     
==========================================
+ Hits        34238    35726    +1488     
- Misses       5226     5865     +639     
Flag Coverage Δ
unittests 85.89% <56.66%> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/framework/message_queue/tests/test_redis.py 61.53% <20.83%> (+28.20%) ⬆️
.../framework/middleware/functional/data_processor.py 90.90% <50.00%> (-0.21%) ⬇️
ding/framework/parallel.py 84.97% <50.00%> (-1.42%) ⬇️
ding/framework/message_queue/redis.py 77.35% <72.22%> (+39.26%) ⬆️
ding/framework/message_queue/nng.py 92.30% <100.00%> (ø)
ding/framework/middleware/learner.py 87.80% <100.00%> (ø)
.../framework/middleware/tests/test_data_processor.py 100.00% <100.00%> (ø)
ding/policy/sac.py 60.50% <0.00%> (-28.12%) ⬇️
ding/utils/data/dataset.py 54.97% <0.00%> (-14.53%) ⬇️
ding/utils/compression_helper.py 93.93% <0.00%> (-6.07%) ⬇️
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c1005...e98ea53. Read the comment docs.

@PaParaZz1 PaParaZz1 added the bug Something isn't working label Jun 7, 2022
@@ -45,7 +45,7 @@ def __call__(self, ctx: "OnlineRLContext") -> None:
Output of ctx:
- train_output (:obj:`Deque`): The training output in deque.
"""
train_output_queue = deque()
train_output_queue = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this modification will conflict with this implementation and its unitttest, please make them compatible.

@PaParaZz1 PaParaZz1 merged commit 0bbd6a5 into main Jul 1, 2022
@PaParaZz1 PaParaZz1 deleted the fix-redis branch July 1, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants