polish(zjow): impala cnn encoder refactor. #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaParaZz1
requested changes
Jun 16, 2022
ding/model/template/vac.py
Outdated
| assert actor_head_hidden_size == critic_head_hidden_size, \ | ||
| "actor and critic network head should have same size." | ||
| if encoder: | ||
| if type(encoder) is torch.nn.Module: |
There was a problem hiding this comment.
if isinstance(encoder, torch.nn.Module):
| "one encoder instance is not allowed \ | ||
| to be assigned to actor critic that not sharing encoders." | ||
| ) | ||
| else: |
There was a problem hiding this comment.
where is you encoder assignment branch, and add corresponding unittest
There was a problem hiding this comment.
fixed.
unittest for encoder assignment is added.
PaParaZz1
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, vac encoder configuration polish.
2, encoder file polish.
3, enrich torch utils.
4, add relative unittest.