Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(whl):add trex example #380

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Conversation

kxzxvbk
Copy link
Contributor

@kxzxvbk kxzxvbk commented Jun 17, 2022

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@@ -20,9 +20,11 @@
checkpoint_step=100,
learning_rate=1e-5,
update_per_collect=1,
num_trajs=6,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we assign num_trajs=6?



if __name__ == "__main__":
main()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not forget to solve the unittest issue

ding/example/trex.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #380 (8345ac1) into main (8c817b6) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   85.91%   85.55%   -0.37%     
==========================================
  Files         524      524              
  Lines       41571    41108     -463     
==========================================
- Hits        35717    35169     -548     
- Misses       5854     5939      +85     
Flag Coverage Δ
unittests 85.55% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/framework/message_queue/tests/test_redis.py 31.25% <0.00%> (-53.60%) ⬇️
ding/framework/message_queue/redis.py 38.09% <0.00%> (-42.86%) ⬇️
ding/framework/message_queue/tests/test_nng.py 40.00% <0.00%> (-33.08%) ⬇️
ding/model/template/atoc.py 86.31% <0.00%> (-8.95%) ⬇️
ding/worker/learner/comm/flask_fs_learner.py 83.12% <0.00%> (-8.75%) ⬇️
ding/entry/tests/test_parallel_entry.py 45.45% <0.00%> (-4.55%) ⬇️
ding/utils/data/dataloader.py 43.52% <0.00%> (-3.63%) ⬇️
ding/world_model/model/tests/test_ensemble.py 71.42% <0.00%> (-2.49%) ⬇️
...envs/env_manager/tests/test_envpool_env_manager.py 36.00% <0.00%> (-2.47%) ⬇️
ding/utils/tests/test_k8s_launcher.py 88.46% <0.00%> (-2.11%) ⬇️
... and 186 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c817b6...8345ac1. Read the comment docs.

@PaParaZz1 PaParaZz1 merged commit c302382 into opendilab:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants