Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zjow): fix bugs in dmc2gym env. #391

Merged
merged 5 commits into from
Jun 23, 2022
Merged

Conversation

zjowowen
Copy link
Collaborator

1, fix the observation dimension error of dmc env "cartpole".
2, fix the observation data type error when it is observed in pixel.
3, try to fix the not response problem when mujoco opengl render, under the condition that the dmc env is both initiated in main thread and subprocess thread.

@zjowowen zjowowen added the bug Something isn't working label Jun 21, 2022
@zjowowen zjowowen self-assigned this Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #391 (bdb34b4) into main (47940ef) will increase coverage by 0.15%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   85.87%   86.03%   +0.15%     
==========================================
  Files         522      522              
  Lines       40835    41234     +399     
==========================================
+ Hits        35069    35474     +405     
+ Misses       5766     5760       -6     
Flag Coverage Δ
unittests 86.03% <50.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/utils/render_helper.py 25.00% <0.00%> (-4.42%) ⬇️
ding/envs/env_manager/base_env_manager.py 90.37% <100.00%> (+0.29%) ⬆️
ding/framework/event_loop.py 92.98% <0.00%> (-3.51%) ⬇️
ding/interaction/tests/test_utils/stream.py 75.00% <0.00%> (-2.78%) ⬇️
ding/interaction/base/network.py 96.34% <0.00%> (-1.25%) ⬇️
ding/framework/parallel.py 85.18% <0.00%> (-1.14%) ⬇️
ding/envs/env_manager/subprocess_env_manager.py 76.78% <0.00%> (-0.65%) ⬇️
ding/framework/middleware/collector.py 87.03% <0.00%> (-0.47%) ⬇️
...worker/replay_buffer/tests/test_advanced_buffer.py 97.80% <0.00%> (-0.44%) ⬇️
ding/worker/replay_buffer/advanced_buffer.py 92.77% <0.00%> (-0.32%) ⬇️
... and 219 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47940ef...bdb34b4. Read the comment docs.

@PaParaZz1 PaParaZz1 merged commit 0f8bd29 into opendilab:main Jun 23, 2022
@ZHZisZZ ZHZisZZ deleted the dmc-debug branch June 24, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants