-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate doc from main repo to doc repo #4
Conversation
Well, is the seperated repository able to build and deploy documentation properly? As I know that the build process of the documentation is based on the source code (or you can say, the pip package), but there will be no source code in doc repo. I think you have to create github action in doc repo and |
.github/workflows/doc.yml
Outdated
make docs | ||
mv ding/docs/build/html public | ||
rm -rf ding/docs/build | ||
git clone https://github.com/opendilab/DI-engine-docs.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider to make a sync with the version of doc repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just restrict to main
branch now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well if you need to edit code and doc, especially when you are using branch, this way may cause problem because the verison of doc not the same.
|
I have another idea, you can consider to use submodule to bind the version of source and docs together. It is a simple way to sync. (Actually as I known, some of the open source python projects' documentation is just in the source repo, with a In the problem of chinese documentation, you can see this official doc, it is usually called 'internationalization' : https://www.sphinx-doc.org/en/master/usage/advanced/intl.html By the way, I'm think about the support of the different versions of |
separate doc from main repo to doc repo
separate doc from main repo to doc repo
doc(README.md): update AutoModelForCausalLM
P.S. unittest can be ignored now, it will be fixed in another pull request.