Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xjx): remove pace controller #400

Merged
merged 1 commit into from
Jun 25, 2022
Merged

fix(xjx): remove pace controller #400

merged 1 commit into from
Jun 25, 2022

Conversation

sailxjx
Copy link
Member

@sailxjx sailxjx commented Jun 24, 2022

pace controller is useless in new pipeline

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #400 (021d1d4) into main (f843b19) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   85.71%   85.86%   +0.14%     
==========================================
  Files         525      523       -2     
  Lines       41471    41457      -14     
==========================================
+ Hits        35546    35595      +49     
+ Misses       5925     5862      -63     
Flag Coverage Δ
unittests 85.86% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/framework/middleware/functional/__init__.py 100.00% <ø> (ø)
ding/envs/env_manager/tests/test_shm.py 88.46% <0.00%> (-3.54%) ⬇️
ding/worker/learner/comm/flask_fs_learner.py 88.75% <0.00%> (-1.82%) ⬇️
ding/framework/parallel.py 85.34% <0.00%> (-0.91%) ⬇️
ding/envs/env/tests/test_ding_env_wrapper.py 72.03% <0.00%> (-0.78%) ⬇️
ding/entry/serial_entry_onpolicy_ppg.py 28.26% <0.00%> (-0.63%) ⬇️
ding/torch_utils/tests/test_data_helper.py 74.84% <0.00%> (-0.48%) ⬇️
ding/envs/env_manager/envpool_env_manager.py 37.34% <0.00%> (-0.46%) ⬇️
ding/entry/serial_entry_ngu.py 19.17% <0.00%> (-0.27%) ⬇️
ding/entry/serial_entry_gail.py 19.14% <0.00%> (-0.21%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f843b19...021d1d4. Read the comment docs.

@PaParaZz1 PaParaZz1 added the bug Something isn't working label Jun 25, 2022
@PaParaZz1 PaParaZz1 merged commit 8c817b6 into main Jun 25, 2022
@PaParaZz1 PaParaZz1 deleted the fix-pace branch June 25, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants