polish(lwq): polish VAE #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaParaZz1
requested changes
Jun 28, 2022
ding/model/template/vae.py
Outdated
| @@ -35,6 +41,12 @@ def loss_function(self, *inputs: Any, **kwargs) -> Tensor: | |||
|
|
|||
|
|
|||
| class VanillaVAE(BaseVAE): | |||
| """ | |||
| Overview: | |||
| Implementation of Vanilla variational autoencoder. | |||
There was a problem hiding this comment.
Implementation of Vanilla variational autoencoder for action reconstruction
ding/model/template/vae.py
Outdated
| @@ -74,17 +84,23 @@ def __init__( | |||
|
|
|||
| def encode(self, input) -> Dict[str, Any]: | |||
ding/model/template/vae.py
Outdated
| @@ -133,15 +147,14 @@ def decode_with_obs(self, z: Tensor, obs: Tensor) -> Dict[str, Any]: | |||
| - outputs (:obj:`Dict`): DQN forward outputs, such as q_value. | |||
| ReturnsKeys: | |||
| - reconstruction_action (:obj:`torch.Tensor`): reconstruction_action. | |||
| - predition_residual (:obj:`torch.Tensor`): predition_residual. | |||
| - predition_residual (:obj:`torch.Tensor`): prediction_residual. | |||
ding/model/template/vae.py
Outdated
| @@ -166,6 +179,21 @@ def reparameterize(self, mu: Tensor, logvar: Tensor) -> Tensor: | |||
| return eps * std + mu | |||
|
|
|||
| def forward(self, input: Tensor, **kwargs) -> dict: | |||
| """ | |||
| Overview: | |||
| encode the input, reparameterize `mu` and `log_var`, decode `obs_encoding`. | |||
Codecov Report
@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 85.61% 85.83% +0.22%
==========================================
Files 524 524
Lines 41108 41571 +463
==========================================
+ Hits 35195 35683 +488
+ Misses 5913 5888 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hcnaeg
force-pushed
the
dev-lwq-polish-vae
branch
from
ba3db61
to
c09778b
Compare
PaParaZz1
approved these changes
Jun 29, 2022
PaParaZz1
pushed a commit
that referenced
this pull request
Jun 30, 2022
* polish(lwq): polish VAE * remove base VAE class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
TODO
Check List