Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] add cartpole test running in k8s cluster #49

Merged
merged 5 commits into from
Sep 13, 2021
Merged

[feature] add cartpole test running in k8s cluster #49

merged 5 commits into from
Sep 13, 2021

Conversation

konnase
Copy link
Contributor

@konnase konnase commented Sep 10, 2021

  • add cartpole dijob managed by di-orchestrator

@konnase
Copy link
Contributor Author

konnase commented Sep 10, 2021

algo_test passed ：https://github.com/konnase/DI-engine/runs/3567070299?check_suite_focus=true

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #49 (c302555) into main (54eb8aa) will decrease coverage by 0.01%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   88.94%   88.93%   -0.02%     
==========================================
  Files         349      349              
  Lines       25967    25972       +5     
==========================================
+ Hits        23097    23098       +1     
- Misses       2870     2874       +4
Flag Coverage Δ
unittests 88.93% <85.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/utils/orchestrator_launcher.py 87.69% <85.00%> (-2.31%) ⬇️
ding/envs/env_manager/subprocess_env_manager.py 82.69% <0.00%> (-0.73%) ⬇️
ding/league/player.py 95.31% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54eb8aa...c302555. Read the comment docs.

PaParaZz1
PaParaZz1 approved these changes Sep 11, 2021
View reviewed changes
Copy link
Member

@PaParaZz1 PaParaZz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can be merged after solving only one comment.

ding/entry/tests/test_serial_entry_algo.py Outdated Show resolved Hide resolved
@PaParaZz1 PaParaZz1 added enhancement New feature or request parallel-dist Parallel and distributed training related labels Sep 11, 2021
@PaParaZz1 PaParaZz1 merged commit 1318901 into opendilab:main Sep 13, 2021
puyuan1996 pushed a commit to puyuan1996/DI-engine that referenced this pull request Dec 14, 2021
@konnase
feature(lqp): add cartpole dqn algorithm test running in k8s cluster (o…
8515323 
…pendilab#49)

* test dijob

* test: wait for dijob Succeeded phase, and read coordinator logs

* test: update wait condition

* ci: update algo_test.yaml and flake check

* test: move kubernetes package to where it will be used
puyuan1996 pushed a commit to puyuan1996/DI-engine that referenced this pull request Apr 18, 2022
@konnase
feature(lqp): add cartpole dqn algorithm test running in k8s cluster (o…
4caed36 
…pendilab#49)

* test dijob

* test: wait for dijob Succeeded phase, and read coordinator logs

* test: update wait condition

* ci: update algo_test.yaml and flake check

* test: move kubernetes package to where it will be used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaParaZz1 PaParaZz1 PaParaZz1 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request parallel-dist Parallel and distributed training related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konnase @codecov-commenter @PaParaZz1