feature(zjow): add trackback log for subprocess env manager #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #534 +/- ##
==========================================
- Coverage 85.48% 85.32% -0.17%
==========================================
Files 526 526
Lines 43300 43305 +5
==========================================
- Hits 37016 36950 -66
- Misses 6284 6355 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zjowowen
changed the title
PaParaZz1
changed the title
PaParaZz1
approved these changes
Nov 2, 2022
| @@ -398,6 +398,7 @@ def reset(self, reset_param: Optional[Dict] = None) -> None: | |||
| self._env_seed[env_id] = None # seed only use once | |||
| except BaseException as e: | |||
| logging.warning("subprocess reset set seed failed, ignore and continue...") | |||
| logging.warning("subprocess exception traceback: \n" + traceback.format_exc()) | |||
| @@ -439,6 +440,7 @@ def reset_fn(): | |||
| reset_fn() | |||
| return | |||
| except BaseException as e: | |||
| logging.warning("subprocess exception traceback: \n" + traceback.format_exc()) | |||
There was a problem hiding this comment.
don't use warning, rather than info, they are catched exception
PaParaZz1
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#532