Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wzl): fix bugs for dict obs in new pipeline #541

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

zerlinwang
Copy link
Collaborator

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the bug Something isn't working label Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #541 (a70f1f3) into dev-eval-viz (7f8c53e) will increase coverage by 0.01%.
The diff coverage is 52.63%.

@@               Coverage Diff                @@
##           dev-eval-viz     #541      +/-   ##
================================================
+ Coverage         85.38%   85.39%   +0.01%     
================================================
  Files               526      526              
  Lines             43367    43373       +6     
================================================
+ Hits              37028    37039      +11     
+ Misses             6339     6334       -5     
Flag Coverage Δ
unittests 85.39% <52.63%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/envs/env_manager/subprocess_env_manager.py 76.71% <0.00%> (+0.14%) ⬆️
ding/torch_utils/__init__.py 100.00% <ø> (ø)
ding/torch_utils/data_helper.py 77.35% <33.33%> (-2.38%) ⬇️
ding/framework/middleware/functional/collector.py 97.10% <100.00%> (+0.04%) ⬆️
ding/framework/middleware/functional/evaluator.py 53.97% <100.00%> (+0.26%) ⬆️
ding/entry/serial_entry_onpolicy.py 95.74% <0.00%> (-0.56%) ⬇️
ding/worker/learner/comm/flask_fs_learner.py 90.62% <0.00%> (ø)
ding/framework/message_queue/redis.py 84.90% <0.00%> (+1.88%) ⬆️
ding/framework/tests/test_parallel.py 96.26% <0.00%> (+3.73%) ⬆️
ding/framework/message_queue/tests/test_nng.py 100.00% <0.00%> (+26.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit 99e97ee into opendilab:dev-eval-viz Nov 10, 2022
PaParaZz1 added a commit that referenced this pull request Nov 12, 2022
* feature(nyz): add evaluator more info viz support

* feature(nyz): add eval policy output viz

* fix(wzl): fix bugs for dict obs in new pipeline (#541)

* fix(wzl): fix bugs for dict dobs in new pipeline

* fix(wzl): use get_shape0 func in new pipeline

* feature(wzl): add newline for style check

* polish(nyz): polish evaluator render implementation

Co-authored-by: zerlinwang <80957609+zerlinwang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants