Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(zjow): add load and save method for replaybuffer #542

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

zjowowen
Copy link
Collaborator

@zjowowen zjowowen commented Nov 10, 2022

#529
Add load_data and save_data for buffer.
Add buffer_saver middleware.
Remove two methods of DequeBuffer: import_data, export_data

@zjowowen zjowowen added the enhancement New feature or request label Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #542 (572b8cd) into main (ce2e0f4) will decrease coverage by 0.08%.
The diff coverage is 92.51%.

@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   85.46%   85.37%   -0.09%     
==========================================
  Files         526      529       +3     
  Lines       43322    43672     +350     
==========================================
+ Hits        37027    37287     +260     
- Misses       6295     6385      +90     
Flag Coverage Δ
unittests 85.37% <92.51%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/framework/middleware/functional/__init__.py 100.00% <ø> (ø)
ding/data/buffer/buffer.py 85.71% <66.66%> (-1.79%) ⬇️
ding/data/buffer/deque_buffer_wrapper.py 60.00% <66.66%> (+0.54%) ⬆️
ding/worker/replay_buffer/base_buffer.py 80.43% <66.66%> (-2.07%) ⬇️
ding/worker/replay_buffer/advanced_buffer.py 92.72% <77.77%> (-0.38%) ⬇️
ding/worker/replay_buffer/naive_buffer.py 88.77% <77.77%> (-0.53%) ⬇️
.../framework/middleware/functional/data_processor.py 90.09% <91.66%> (+0.21%) ⬆️
ding/data/buffer/deque_buffer.py 97.97% <100.00%> (+0.04%) ⬆️
ding/data/buffer/tests/test_buffer.py 100.00% <100.00%> (ø)
...ework/middleware/tests/test_advantage_estimator.py 100.00% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 changed the title feature(zjow): Add load and save method for replaybuffer feature(zjow): add load and save method for replaybuffer Nov 14, 2022
ding/data/buffer/deque_buffer.py Show resolved Hide resolved
ding/data/buffer/deque_buffer.py Show resolved Hide resolved
ding/data/buffer/tests/test_buffer.py Show resolved Hide resolved
ding/framework/middleware/functional/data_processor.py Outdated Show resolved Hide resolved
ding/framework/middleware/functional/data_processor.py Outdated Show resolved Hide resolved
ding/framework/middleware/functional/data_processor.py Outdated Show resolved Hide resolved
ding/framework/middleware/functional/data_processor.py Outdated Show resolved Hide resolved
ding/framework/middleware/functional/data_processor.py Outdated Show resolved Hide resolved
@PaParaZz1 PaParaZz1 merged commit bceb05b into opendilab:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants