Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(nyz): add MADDPG algo #550

Merged
merged 4 commits into from
Dec 4, 2022
Merged

feature(nyz): add MADDPG algo #550

merged 4 commits into from
Dec 4, 2022

Conversation

PaParaZz1
Copy link
Member

@PaParaZz1 PaParaZz1 commented Dec 1, 2022

Description

There is a demo in multiagent_mujoco, we don't fine-tune the hyper-parameters:

Screen Shot 2022-12-04 at 7 25 22 PM

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the algo Add new algorithm or improve old one label Dec 1, 2022
@PaParaZz1 PaParaZz1 changed the title feature(nyz): add basic maddpg feature(nyz): add MADDPG algo Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #550 (91dc638) into main (4c607d4) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

❗ Current head 91dc638 differs from pull request most recent head cdabc2e. Consider uploading reports for the commit cdabc2e to get more accurate results

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   85.40%   85.38%   -0.03%     
==========================================
  Files         532      532              
  Lines       43859    43861       +2     
==========================================
- Hits        37458    37449       -9     
- Misses       6401     6412      +11     
Flag Coverage Δ
unittests 85.38% <85.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/policy/td3.py 100.00% <ø> (ø)
ding/policy/ddpg.py 87.83% <66.66%> (-0.52%) ⬇️
ding/policy/sac.py 60.36% <100.00%> (-0.15%) ⬇️
ding/policy/td3_bc.py 89.24% <100.00%> (+0.23%) ⬆️
ding/framework/message_queue/tests/test_redis.py 61.53% <0.00%> (-38.47%) ⬇️
ding/framework/message_queue/redis.py 79.24% <0.00%> (-3.78%) ⬇️
ding/envs/env_manager/subprocess_env_manager.py 77.49% <0.00%> (+0.78%) ⬆️
ding/worker/learner/comm/flask_fs_learner.py 91.87% <0.00%> (+1.25%) ⬆️
ding/framework/event_loop.py 96.49% <0.00%> (+3.50%) ⬆️
ding/framework/tests/test_parallel.py 96.26% <0.00%> (+3.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit e028d36 into main Dec 4, 2022
@PaParaZz1 PaParaZz1 deleted the dev-maddpg branch December 4, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algo Add new algorithm or improve old one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant