Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(nyz): add ppof ch3 demo #581

Merged
merged 6 commits into from
Feb 13, 2023
Merged

feature(nyz): add ppof ch3 demo #581

merged 6 commits into from
Feb 13, 2023

Conversation

PaParaZz1
Copy link
Member

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the enhancement New feature or request label Feb 12, 2023
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #581 (dc47515) into main (d489313) will decrease coverage by 0.15%.
The diff coverage is 32.11%.

❗ Current head dc47515 differs from pull request most recent head f28ab6f. Consider uploading reports for the commit f28ab6f to get more accurate results

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   83.68%   83.53%   -0.15%     
==========================================
  Files         564      564              
  Lines       46110    46194      +84     
==========================================
+ Hits        38585    38588       +3     
- Misses       7525     7606      +81     
Flag Coverage Δ
unittests 83.53% <32.11%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/bonus/config.py 0.00% <0.00%> (ø)
ding/bonus/ppof.py 0.00% <0.00%> (ø)
ding/envs/env_manager/subprocess_env_manager.py 76.18% <ø> (+0.76%) ⬆️
ding/model/common/__init__.py 100.00% <ø> (ø)
ding/policy/ppof.py 16.47% <0.00%> (-0.39%) ⬇️
ding/model/common/head.py 96.86% <37.50%> (-1.71%) ⬇️
ding/model/common/encoder.py 94.28% <50.00%> (-1.37%) ⬇️
ding/utils/compression_helper.py 71.92% <63.63%> (-1.99%) ⬇️
ding/envs/env/ding_env_wrapper.py 85.52% <78.57%> (-1.70%) ⬇️
ding/utils/__init__.py 96.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit d03893a into main Feb 13, 2023
@PaParaZz1 PaParaZz1 deleted the dev-ppof-ch3 branch February 13, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant