feature(lxy): modify ppof rewardclip and add atari config #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
==========================================
- Coverage 83.53% 83.50% -0.04%
==========================================
Files 564 564
Lines 46201 46241 +40
==========================================
+ Hits 38596 38613 +17
- Misses 7605 7628 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PaParaZz1
requested changes
Mar 3, 2023
ding/bonus/config.py
Outdated
| @@ -77,6 +77,39 @@ def get_instance_config(env: str) -> EasyDict: | |||
| critic_head_hidden_size=256, | |||
| actor_head_hidden_size=256, | |||
| ) | |||
| elif env == 'qbert': | |||
There was a problem hiding this comment.
qbert can use the same config as kangaroo and bowling
ding/bonus/config.py
Outdated
| @@ -152,6 +185,36 @@ def get_instance_env(env: str) -> BaseEnv: | |||
| }, | |||
| seed_api=False, | |||
| ) | |||
| elif env == 'qbert': | |||
There was a problem hiding this comment.
unify these code and remove unused code
ding/bonus/config.py
Outdated
| @@ -152,6 +185,36 @@ def get_instance_env(env: str) -> BaseEnv: | |||
| }, | |||
| seed_api=False, | |||
| ) | |||
| elif env == 'qbert': | |||
ding/bonus/ppof.py
Outdated
| @@ -86,7 +91,7 @@ def train( | |||
| logging.debug(self.policy._model) | |||
| # define env and policy | |||
| collector_env = self._setup_env_manager(collector_env_num, context, debug) | |||
PaParaZz1
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
TODO
Check List