Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(gry): add MDQN algorithm #590

Merged
merged 41 commits into from
Mar 8, 2023
Merged

Conversation

ruoyuGao
Copy link
Contributor

@ruoyuGao ruoyuGao commented Feb 21, 2023

Description

Implementation of Munchausen Reinforcement Learning

Experiment result (Asterix)

Reward

asterix

Action gap

action_gap

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #590 (1f72e24) into main (55898a3) will increase coverage by 0.22%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
+ Coverage   83.39%   83.61%   +0.22%     
==========================================
  Files         564      565       +1     
  Lines       45781    46407     +626     
==========================================
+ Hits        38178    38804     +626     
  Misses       7603     7603              
Flag Coverage Δ
unittests 83.61% <95.23%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/policy/mdqn.py 90.00% <90.00%> (ø)
ding/entry/serial_entry.py 96.92% <100.00%> (ø)
ding/policy/__init__.py 100.00% <100.00%> (ø)
ding/policy/command_mode_policy_instance.py 93.49% <100.00%> (+0.10%) ⬆️
ding/rl_utils/__init__.py 100.00% <100.00%> (ø)
ding/rl_utils/td.py 93.34% <100.00%> (+0.37%) ⬆️
ding/rl_utils/tests/test_td.py 100.00% <100.00%> (ø)
ding/framework/event_loop.py 90.16% <0.00%> (-3.28%) ⬇️
ding/interaction/tests/test_utils/stream.py 75.00% <0.00%> (-2.78%) ⬇️
ding/worker/collector/comm/flask_fs_collector.py 89.38% <0.00%> (-0.89%) ⬇️
... and 213 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 added the algo Add new algorithm or improve old one label Feb 22, 2023
dizoo/atari/config/serial/Asterix/__init__.py Outdated Show resolved Hide resolved
ding/rl_utils/tests/test_td.py Outdated Show resolved Hide resolved
dizoo/atari/config/serial/Asterix/asterix_mdqn_config.py Outdated Show resolved Hide resolved
dizoo/atari/config/serial/Asterix/asterix_mdqn_config.py Outdated Show resolved Hide resolved
dizoo/atari/config/serial/Asterix/asterix_mdqn_config.py Outdated Show resolved Hide resolved
ding/policy/mdqn.py Outdated Show resolved Hide resolved
ding/policy/mdqn.py Outdated Show resolved Hide resolved
ding/policy/mdqn.py Outdated Show resolved Hide resolved
@ruoyuGao ruoyuGao requested a review from PaParaZz1 March 2, 2023 22:44
ding/policy/dqn.py Outdated Show resolved Hide resolved
ding/policy/dqn.py Outdated Show resolved Hide resolved
ding/rl_utils/td.py Outdated Show resolved Hide resolved
ding/rl_utils/tests/test_td.py Outdated Show resolved Hide resolved
dizoo/atari/config/serial/asterix/asterix_mdqn_config.py Outdated Show resolved Hide resolved
dizoo/atari/config/serial/asterix/asterix_mdqn_config.py Outdated Show resolved Hide resolved
ding/policy/dqn.py Outdated Show resolved Hide resolved
ding/policy/dqn.py Outdated Show resolved Hide resolved
@ruoyuGao ruoyuGao requested a review from PaParaZz1 March 7, 2023 05:03
ding/entry/serial_entry.py Outdated Show resolved Hide resolved
ding/entry/serial_entry.py Outdated Show resolved Hide resolved
ding/entry/tests/test_serial_entry.py Show resolved Hide resolved
ding/policy/mdqn.py Show resolved Hide resolved
ding/rl_utils/td.py Outdated Show resolved Hide resolved
dizoo/atari/config/serial/asterix/asterix_mdqn_config.py Outdated Show resolved Hide resolved
@ruoyuGao ruoyuGao force-pushed the ruoyugao branch 2 times, most recently from 04bc97b to 55e2428 Compare March 7, 2023 06:16
@PaParaZz1 PaParaZz1 merged commit 741fe40 into opendilab:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algo Add new algorithm or improve old one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants