Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(nyz): polish model template comments #722

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Conversation

PaParaZz1
Copy link
Member

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the doc Documentation label Sep 10, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #722 (270abc0) into main (3059479) will decrease coverage by 0.78%.
Report is 8 commits behind head on main.
The diff coverage is 66.51%.

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   80.68%   79.90%   -0.78%     
==========================================
  Files         598      599       +1     
  Lines       50116    49531     -585     
==========================================
- Hits        40434    39578     -856     
- Misses       9682     9953     +271     
Flag Coverage Δ
unittests 79.90% <66.51%> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ding/entry/__init__.py 100.00% <ø> (ø)
ding/envs/env_manager/__init__.py 100.00% <ø> (ø)
ding/model/common/head.py 95.51% <ø> (+0.30%) ⬆️
ding/model/template/bc.py 94.23% <ø> (ø)
ding/policy/dqn.py 80.21% <ø> (ø)
ding/policy/td3_vae.py 13.27% <0.00%> (ø)
ding/torch_utils/__init__.py 100.00% <ø> (ø)
ding/policy/prompt_pg.py 25.00% <25.00%> (ø)
.../model/template/tests/test_language_transformer.py 26.66% <26.66%> (ø)
ding/model/template/language_transformer.py 29.41% <29.41%> (ø)
... and 34 more

... and 221 files with indirect coverage changes

@PaParaZz1 PaParaZz1 merged commit a07cde2 into main Sep 13, 2023
33 of 39 checks passed
@PaParaZz1 PaParaZz1 deleted the dev-polish-model-comments branch September 13, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant