feature(zjow): add qgpo policy for new DI-engine pipeline #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaParaZz1
requested changes
Dec 20, 2023
PaParaZz1
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 76.82% 75.80% -1.03%
==========================================
Files 676 679 +3
Lines 54328 55272 +944
==========================================
+ Hits 41737 41897 +160
- Misses 12591 13375 +784
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PaParaZz1
requested changes
Dec 28, 2023
zjowowen
commented
Jan 3, 2024
zjowowen
commented
Jan 3, 2024
zjowowen
commented
Jan 3, 2024
zjowowen
commented
Jan 3, 2024
zjowowen
commented
Jan 3, 2024
ding/policy/qgpo.py
Outdated
| self.qt_update_momentum * param.data + (1 - self.qt_update_momentum) * target_param.data | ||
| ) | ||
|
|
||
| q0_loss = q0_loss.detach().cpu().numpy() |
There was a problem hiding this comment.
replace detach() by item()
zjowowen
commented
Jan 3, 2024
zjowowen
commented
Jan 3, 2024
zjowowen
commented
Jan 3, 2024
zjowowen
commented
Feb 4, 2024
| @@ -611,6 +611,9 @@ def _plot(ctx: "OfflineRLContext"): | |||
| ) | |||
|
|
|||
| if ctx.eval_value != -np.inf: | |||
| if hasattr(ctx, "info_for_logging"): | |||
| info_for_logging.update(ctx.info_for_logging) | |||
There was a problem hiding this comment.
add comment for it
PaParaZz1
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add qgpo policy for new DI-engine pipeline based on the implementation of repo https://github.com/ChenDRAG/CEP-energy-guided-diffusion.