This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Adds Cypress E2E tests and GitHub Action Cypress workflow #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftianli-amzn
requested review from
dbbaughe,
qreshi,
mihirsoni,
gaiksaya and
bowenlan-amzn
June 19, 2020 05:03
ftianli-amzn
changed the title
Adds Cypress E2E tests and GitHub Action Cypress workflow (from a temp branch within the repo)
Adds Cypress E2E tests and GitHub Action Cypress workflow
Aug 25, 2020
* install cypress module * Add Cypress test cases of basic Monitor CRUD operations * Add Cypress test cases of Destination CRUD operations and add destination to monitors * Add Cypress test cases of different Alert states * Clean up cypress example files * Add GitHub Action workflow file for Cypress test * Update README file
* Adds support for Kibana 7.8.0 (#163) * Bump version number of ES, ODFE, and node * update Jest snapshots * update release notes with Kibana 7.8.0 support * Move plugin entry into Kibana app category in sidebar (cherry picked from commit bf9a91c) * Update the unit-test workflow script to get Kibana version from package.json (#165) * Get Kibana version from the package.json file in unit-test workflow (cherry picked from commit 6d82e56) * Fix the unit-test workflow by checking out the repo first (cherry picked from commit cc9fc0c) * Bump lodash from 4.17.15 to 4.17.19 (#169) * Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> * update yarn.lock by running 'yarn kbn bootstrap' Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tianli Feng <ftianli@amazon.com> (cherry picked from commit 8b0dd58) * Adds support for Kibana 7.9.0 (#171) * keyCode to key * fix UT * remove used dependency (cherry picked from commit 5d3ff53) * Release note automate (#172) * release note automation * python script fix * compatibale with Kibana (cherry picked from commit c72d37e) * upgrade cypress verison to 5.0.0 * ingonre an uncaught error and add some copyright notice * change a wording back Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>
ftianli-amzn
force-pushed
the
cypress_od1.8
branch
from
August 25, 2020 06:05
812b01d
to
3a51a37
Compare
#174) * Update opendistro-for-elasticsearch-alerting-kibana-plugin.release-notes-1.10.0.0.md * paranthesis * time * paranthesis
* release workflow
* Add Mail destination * Support SSL/TLS * Authentification * Message's body is html by dedault * Rework mail destination : - all mail server settings are in elasticsearch.yml - remove html support for now * Changed references to 'Mail' to 'Email' * Add routes and services for EmailAccount and EmailGroup APIs * Add styles for accordion-separator and 'Manage senders' modal * Add 'Email sender' selection and 'Manage senders' modal to 'Create destination' page for Email destinations * Add 'Email recipients' and 'Manage email groups' modal to 'Create destination' page for Email destinations * Load senders in ManageSenders to decouple modal from EmailSender * Fix bug that nested options in EmailGroup emails combo box * Load email groups in ManageEmailGroups to decouple modal from EmailRecipients * Move 'onClickSave' processing logic from EmailSender to ManageSender * Move 'onClickSave' processing logic from EmailRecipients to ManageEmailGroups * Add 'Actions' dropdown for managing email senders and email groups from the Destinations page * Fix styling on manage email sender and email group modals * Prevent ManageSenders and ManageEmailGroups modals from closing with ESCAPE key * Move state changing anonymous arrow functions to component functions * Pass httpClient to getSenders() and getEmailGroups() * Show invalid emails entered in Email Group form and fix issue with duplicate options appearing * Update help text for Sender 'method' selection * Update formikToDestination for Email type * Move email_accounts and email_groups APIs under 'destinations' namespace * Update destinationToFormik for Email type * Update validateEmailRecipients to return all invalid email entries * Increase width for Email modals empty prompts for better text wrapping * Fix text misalignment for Sender form when there is validation text * Add toast messages on success and failure for Sender and EmailGroup modals * Hide modal footers for Sender and EmailGroup modals when there is nothing to save * Make email verification RFC 5322 compliant * Comma separate invalid emails in validation text * Add initial tests for ManageSenders and ManageEmailGroups * Update destinationToFormik tests to await on asynchronous parts * Update snapshots * Add updated yarn.lock Co-authored-by: David Chauvière <david.chauviere@orange.com> Co-authored-by: David Chauviere <David Chauviere david.chauviere@orange.com>
…nation (#189) * Remove dashes from valid sender name requirements * Add additional tests for email changes
* Update MonitorService handler to use rest apis instead of calling config index * Use HTTPS for Monitor api calls * Revert MonitorService changes and add support to call getDestination(s) rest API * add support for calling getAlerts api * fix pagination and sorting, also call rest api for getMonitor(s) * fix sorting, filtering, and searching for getAlerts and getDestinations * Call Alerting Rest APIs instead of alerting/config index * minor fixes
…rd and Detail page (#187) * Showing monitor creator in monitor overview and dashboard * Display 'N/A' as the user name when there is no 'user' field in a monitor * add comments to explain all the cases of the user object * update jest snapshot files and a unit test for 'getOverviewStats'
…d to create/update a monitor or destination (#168) * Add a toast error message if the form validation fails when user attempts to create or edit a monitor. * Auto scroll the page to the first field with error, and focus the field. * Add a toast error message to show the REST API errors when user attempts to create or edit a monitor.
* Add utility function to get destination ALLOW_LIST * Hide 'Actions' on Destination page if email is disallowed and prevent 'Edit' on disallowed Destinations * Filter on allowed destinations in ConfigureActions and CreateDestination * Disable 'Edit' button for disallowed Destinations * Don't load initialValues for Email modals when Email is disallowed * Add validation for disallowed destinations during Create/Edit Destination page * Show message in modals when Email destination is disallowed * Update Email modal tests * Filter out disallowed destinations in DestinationsControls * Update tests for DestinationsList, DestinationsActions and DestinationsControls * Update snapshots * Fix bug in AlertService * Refactor getAllowList() function and setting resolution order * Reload modals when isEmailAllowed property changes
* Update version to 1.11.0.0 * fix notes
* Fix Monitor Details Page * fix tests and others
…g/updating a trigger (#201)
ftianli-amzn
requested review from
annie3431,
lezzago,
qreshi and
skkosuri-amzn
and removed request for
dbbaughe,
bowenlan-amzn,
annie3431,
lezzago,
qreshi and
skkosuri-amzn
January 7, 2021 19:15
ftianli-amzn
requested review from
dbbaughe,
bowenlan-amzn,
annie3431,
lezzago,
qreshi and
skkosuri-amzn
January 7, 2021 23:45
Last run before changing the trigger of the workflow from |
skkosuri-amzn
approved these changes
Jan 12, 2021
qreshi
reviewed
Jan 12, 2021
qreshi
approved these changes
Jan 12, 2021
lezzago
approved these changes
Jan 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Active
stateAcknowledged
stateCompleted
stateError
stateDeleted
statemaster
branchReferences of the code changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.