Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Upgrade to ES/Kibana version v7.9.1 #101

Merged

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Sep 29, 2020

Issue #, if available:

Description of changes:
Upgrade to ES/Kibana version v7.9.1 for both reports-scheduler plugin and kibana-reports plugin

  • Kibana reports plugin

    • server
      • replace IClusterClient ,IScopedClusterClient toILegacyClusterClient, ILegacyScopedClusterClient
      • replace ...dataClient.callAsCurrentUser to ...legacy.client.callAsCurrentUser
    • UI
      • add data to kibana.json -> requiredPlugins
  • Reports scheduler

    • bump version/dependency number
  • This update also solves one of the kibana plugin build issue in plugin fails to run after installed to kibana #40. The issue that kibana-plugin-helper didn't pick up hidden files started with dot, which in our case is the .local-chromium

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -19,7 +19,7 @@ import {
CoreStart,
Plugin,
Logger,
IClusterClient,
ILegacyClusterClient,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We revert back to legacy for 7.9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the IClusterClient in kibana v7.9.1 is not fully supported for our usage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the UI still render with the version change when navigating to the Reporting homepage?

@zhongnansu
Copy link
Member Author

Does the UI still render with the version change when navigating to the Reporting homepage?

The only issues that UI is complaining is the now it requires a data plugins in the kibana.json. Everything looks good after I added that

Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongnansu zhongnansu merged commit cc06c87 into opendistro-for-elasticsearch:dev Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants