-
Notifications
You must be signed in to change notification settings - Fork 31
Upgrade to ES/Kibana version v7.9.1 #101
Upgrade to ES/Kibana version v7.9.1 #101
Conversation
@@ -19,7 +19,7 @@ import { | |||
CoreStart, | |||
Plugin, | |||
Logger, | |||
IClusterClient, | |||
ILegacyClusterClient, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We revert back to legacy for 7.9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the IClusterClient
in kibana v7.9.1 is not fully supported for our usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the UI still render with the version change when navigating to the Reporting homepage?
The only issues that UI is complaining is the now it requires a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available:
Description of changes:
Upgrade to ES/Kibana version v7.9.1 for both reports-scheduler plugin and kibana-reports plugin
Kibana reports plugin
IClusterClient
,IScopedClusterClient
toILegacyClusterClient
,ILegacyScopedClusterClient
...dataClient.callAsCurrentUser
to...legacy.client.callAsCurrentUser
data
tokibana.json
->requiredPlugins
Reports scheduler
This update also solves one of the kibana plugin build issue in plugin fails to run after installed to kibana #40. The issue that
kibana-plugin-helper
didn't pick up hidden files started with dot, which in our case is the.local-chromium
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.