This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
[Bug Fix] Context menu doesn't show up when switching between tabs from sidebar #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
changed the title
zhongnansu
requested review from
akbhatta,
davidcui1225,
joshuali925 and
anirudha
davidcui1225
approved these changes
Nov 5, 2020
joshuali925
approved these changes
Nov 5, 2020
akbhatta
approved these changes
Nov 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
context menu doesn't show up when switching between dashboards & visualizations from sidebar (i.e URL change but no hash change)
Description of changes:
When navigating to tabs from Kibana sidebar, it uses
history.pushState, which doesn't triggerwindow.onHashchange.Taking solution provided from the following link, to monkey patch event and add event listener. https://stackoverflow.com/questions/4570093/how-to-get-notified-about-changes-of-the-history-via-history-pushstate/4585031
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.