This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Migrate all Kibana server side APIs to call ES-reporting APIs #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
requested review from
davidcui1225,
akbhatta,
joshuali925,
anirudha and
abbashus
and removed request for
abbashus
| @@ -74,6 +81,7 @@ export const createReport = async ( | |||
| ); | |||
| } else { | |||
| // report source can only be one of [saved search, visualization, dashboard] | |||
| // Check if security is enabled. TODO: is there a better way to check? | |||
There was a problem hiding this comment.
Whats the current check for if security is enabled? the if block with the request.headers.cookie object?
There was a problem hiding this comment.
From my test, if security is not enabled, request.header.cookie will be undefined
davidcui1225
approved these changes
Nov 10, 2020
akbhatta
approved these changes
Nov 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Major Change
Minor
TODO:
fromIndexparameter forgetAllAPIsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.