Use commonlyUsedRanges from Kibana Settings instead of a constant value
#352
Conversation
iget-master
changed the title
commonlyUsedRanges from Kibana Settings instead of a constant value
Codecov Report
@@ Coverage Diff @@
## dev #352 +/- ##
============================================
+ Coverage 64.12% 64.16% +0.03%
Complexity 291 291
============================================
Files 100 101 +1
Lines 4081 4085 +4
Branches 622 621 -1
============================================
+ Hits 2617 2621 +4
Misses 1304 1304
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
akbhatta
requested review from
davidcui1225,
zhongnansu,
akbhatta and
joshuali925
| http: CoreStart['http']; | ||
| navigation: NavigationPublicPluginStart; | ||
| // navigation: NavigationPublicPluginStart; |
There was a problem hiding this comment.
If navigation and notifications are not used anywhere, please remove them from code, instead of comment it out.
@joshuali925 @davidcui-amzn could you confirm that it's safe to remove those 2?
There was a problem hiding this comment.
@davidcui-amzn can you take a look, and if it's safe to remove this, let's merge in the PR first
There was a problem hiding this comment.
Can confirm, navigation and notifications are not used. Please remove them instead of commenting out, as Zhongnan suggests above.
| @@ -13,13 +13,16 @@ | |||
| * permissions and limitations under the License. | |||
| */ | |||
|
|
|||
| import { NavigationPublicPluginStart } from '../../../src/plugins/navigation/public'; | |||
| // import { NavigationPublicPluginStart } from '../../../src/plugins/navigation/public'; | |||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | ||
| export interface OpendistroKibanaReportsPluginStart {} | ||
|
|
||
| export interface AppPluginStartDependencies { | ||
| navigation: NavigationPublicPluginStart; | ||
| // navigation: NavigationPublicPluginStart; |
| { notifications, http, chrome }: CoreStart, | ||
| { navigation }: AppPluginStartDependencies, | ||
| { http, chrome, uiSettings }: CoreStart, | ||
| { }: AppPluginStartDependencies, |
There was a problem hiding this comment.
No, the parameter for AppPluginStartDependencies was navigation previously, which is not used
|
I'm moving this PR to https://github.com/opensearch-project/dashboards-reports with the requested changes. I think this repository will be cloded, right? |
|
Moved to opensearch-project/reporting#49 |
Issue #, if available: #351
Description of changes:
uiSettingsservice fromDataplugin as dependencytime_rangecomponent to usecommonlyUsedRangesfromuiSettings(following default behavior forEuiSuperDatePickeracross entire kibana), allowing user to override defaultscommonlyUsedRangesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.