Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Improve sanity tests #361

Merged

Conversation

uzhinskiy
Copy link
Contributor

Pass processing if doc[field] == null
Based on #327 (comment)

Issue #327 :

Description of changes:
Calling doc [field] .toString () for null-values was throwing an error. Added check for null-value.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (dev@1fa90d8). Click here to learn what that means.
The diff coverage is 50.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #361   +/-   ##
======================================
  Coverage       ?   64.11%           
  Complexity     ?      291           
======================================
  Files          ?      100           
  Lines          ?     4083           
  Branches       ?      622           
======================================
  Hits           ?     2618           
  Misses         ?     1305           
  Partials       ?      160           
Flag Coverage Δ Complexity Δ
Kibana-reports 77.27% <50.00%> (?) 0.00 <0.00> (?)
reports-scheduler 53.28% <ø> (?) 291.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...a-reports/server/routes/utils/dataReportHelpers.ts 59.25% <50.00%> (ø) 0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa90d8...a0d6900. Read the comment docs.

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix- could you also add a small test case for this change as well?

@zhongnansu
Copy link
Member

No response, let's merge it in and add the test case by ourself

@zhongnansu zhongnansu merged commit 368eb03 into opendistro-for-elasticsearch:dev May 11, 2021
@zhongnansu zhongnansu added the need migrate need migrate to OpenSearch label May 11, 2021
@zhongnansu zhongnansu removed the need migrate need migrate to OpenSearch label Jun 8, 2021
@anirudha anirudha changed the title Pass processing if doc[field] == null Improve sanity tests Jun 25, 2021
zhongnansu pushed a commit to zhongnansu/kibana-reports that referenced this pull request Jul 1, 2021
zhongnansu pushed a commit to zhongnansu/kibana-reports that referenced this pull request Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants