-
Notifications
You must be signed in to change notification settings - Fork 31
Improve sanity tests #361
Improve sanity tests #361
Conversation
Pass processing if doc[field] == null Based on opendistro-for-elasticsearch#327 (comment)
Codecov Report
@@ Coverage Diff @@
## dev #361 +/- ##
======================================
Coverage ? 64.11%
Complexity ? 291
======================================
Files ? 100
Lines ? 4083
Branches ? 622
======================================
Hits ? 2618
Misses ? 1305
Partials ? 160
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix- could you also add a small test case for this change as well?
No response, let's merge it in and add the test case by ourself |
Pass processing if doc[field] == null Based on opendistro-for-elasticsearch#327 (comment)
Pass processing if doc[field] == null Based on opendistro-for-elasticsearch#327 (comment)
Pass processing if doc[field] == null
Based on #327 (comment)
Issue #327 :
Description of changes:
Calling doc [field] .toString () for null-values was throwing an error. Added check for null-value.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.