This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Hooked Edit report definition APIs #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
requested review from
seraphjiang,
mihirsoni,
joshuali925 and
zhongnansu
joshuali925
reviewed
Aug 17, 2020
public/components/report_definitions/report_settings/report_settings.tsx
Outdated
Show resolved
Hide resolved
akbhatta
approved these changes
Aug 20, 2020
| report_params: { | ||
| url: ``, | ||
| report_format: '', | ||
| window_width: 1560, |
There was a problem hiding this comment.
is this hardcoding required?
public/components/report_definitions/report_settings/report_settings.tsx
Outdated
Show resolved
Hide resolved
public/components/report_definitions/report_settings/report_settings.tsx
Outdated
Show resolved
Hide resolved
zhongnansu
approved these changes
Sep 3, 2020
kibana-reports/public/components/report_definitions/edit/edit_report_definition.tsx
Outdated
Show resolved
Hide resolved
kibana-reports/public/components/report_definitions/edit/edit_report_definition.tsx
Outdated
Show resolved
Hide resolved
kibana-reports/public/components/report_definitions/report_settings/report_settings.tsx
Outdated
Show resolved
Hide resolved
...a-reports/public/components/report_definitions/report_settings/report_settings_constants.tsx
Outdated
Show resolved
Hide resolved
zhongnansu
added a commit
to zhongnansu/kibana-reports
that referenced
this pull request
May 25, 2021
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Hooked Edit report APIs to front-end
ReportSettings,ReportTriggerandDeliveryDelivery, extracted EmailDelivery component so default report definition values could be populated in EditBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.