This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix workbench bugs from plugin platform upgrade #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #886 +/- ##
==========================================
Coverage 99.85% 99.85%
Complexity 2148 2148
==========================================
Files 216 216
Lines 4845 4845
Branches 318 318
==========================================
Hits 4838 4838
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
davidcui1225
approved these changes
Dec 3, 2020
joshuali925
changed the title
chloe-zh
approved these changes
Dec 7, 2020
joshuali925
added a commit
that referenced
this pull request
Dec 7, 2020
* Fix download json api path * Fix cypress tests * Fix response tab margin * Update cypress tests * Fix server log message * Fix asScoped call for security plugin * Update cypress tests * Fix unique keys problem * Remove console log
chloe-zh
pushed a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
…icsearch#886) * Fix download json api path * Fix cypress tests * Fix response tab margin * Update cypress tests * Fix server log message * Fix asScoped call for security plugin * Update cypress tests * Fix unique keys problem * Remove console log
chloe-zh
pushed a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
…icsearch#886) * Fix download json api path * Fix cypress tests * Fix response tab margin * Update cypress tests * Fix server log message * Fix asScoped call for security plugin * Update cypress tests * Fix unique keys problem * Remove console log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
/api/sql_console/sqljsoninstead of/api/sql_console/queryjson{ body: `{ "query": "${query}" }` }from{ query: query }so we no longer needconvertQueryToString(ref: Migrate Query Workbench to new Platform #812 (comment))client.asScoped(request), so it works with security pluginBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.