Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Extend the PPL identifier defintion #888

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Dec 4, 2020

Issue #, if available: #882

Description of changes:

  1. Update the doc to support Elasticsearch extension as identifier. https://github.com/penghuo/sql/blob/issue-882/docs/experiment/ppl/general/identifiers.rst

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #888 (d7bbb3c) into develop (f47e9fc) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #888   +/-   ##
==========================================
  Coverage      99.85%   99.85%           
- Complexity      2132     2145   +13     
==========================================
  Files            215      216    +1     
  Lines           4774     4832   +58     
  Branches         313      318    +5     
==========================================
+ Hits            4767     4825   +58     
  Misses             5        5           
  Partials           2        2           
Impacted Files Coverage Δ Complexity Δ
...ch/planner/logical/rule/OptimizationRuleUtils.java 100.00% <0.00%> (ø) 6.00% <0.00%> (+4.00%)
.../planner/logical/ElasticsearchLogicalIndexAgg.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
...ge/script/aggregation/AggregationQueryBuilder.java 100.00% <0.00%> (ø) 7.00% <0.00%> (+1.00%)
...ript/aggregation/dsl/BucketAggregationBuilder.java 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
...ical/ElasticsearchLogicalPlanOptimizerFactory.java 100.00% <0.00%> (ø) 1.00% <0.00%> (ø%)
...rch/planner/logical/rule/MergeSortAndIndexAgg.java 100.00% <0.00%> (ø) 8.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47e9fc...d7bbb3c. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@penghuo penghuo merged commit 7dc8699 into opendistro-for-elasticsearch:develop Dec 4, 2020
@penghuo penghuo deleted the issue-882 branch December 4, 2020 16:48
joshuali925 pushed a commit that referenced this pull request Dec 7, 2020
* Extend the PPL identifier defintion

* update

* fix bug
penghuo added a commit that referenced this pull request Dec 15, 2020
* Extend the PPL identifier defintion

* update

* fix bug
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants