Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plain text #281

Merged
merged 19 commits into from
Nov 21, 2021
Merged

plain text #281

merged 19 commits into from
Nov 21, 2021

Conversation

andiwand
Copy link
Member

@andiwand andiwand commented Nov 1, 2021

Copy link
Member

@TomTasche TomTasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could easily add editing for TextFile too?

crazy idea: what if we convert additional formats (like txt and csv) into ODF (odt and ods) and display them like that?

include/odr/html.h Outdated Show resolved Hide resolved
@andiwand
Copy link
Member Author

andiwand commented Nov 1, 2021

@TomTasche

the only challenge with editing is how to communicate the diff. the easiest is to pass the whole content of the txt but that's not pretty and wont scale well.

the problem with converting files is that you have to infer information like font and size and paragraphs. later when you want to save the changes into the original format you have to convert backwards and therefore double the chance of breaking something in the document

@andiwand andiwand marked this pull request as ready for review November 2, 2021 09:16
@andiwand
Copy link
Member Author

holding back because it breaks iOS builds

@andiwand andiwand merged commit 12a4cc0 into master Nov 21, 2021
@andiwand andiwand deleted the feature/plain-text branch November 21, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants