This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Move away from VIPS for bimg #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassox
requested review from
zain,
rach,
connorjacobsen,
openskydoor and
visnup
openskydoor
reviewed
Aug 9, 2017
main.go
Outdated
| Quality: 50, | ||
| }) | ||
| }); |
bin/install
Outdated
| @@ -1,6 +1,6 @@ | |||
| #!/bin/bash | |||
|
|
|||
| brew install --devel go | |||
| brew install go | |||
There was a problem hiding this comment.
you may be able to do something like go@1.8 to lock it to a specific version instead of just the latest (I know --devel was even more dangerous...)
|
@openskydoor @connorjacobsen great feedback... I"m not sure how to do it ;) Can we pair on the changes suggested? |
openskydoor
force-pushed
the
move-away-from-vips
branch
from
644e87f to
e870ae1
Compare
|
@raroman What's the status on this? |
connorjacobsen
approved these changes
Sep 15, 2017
We noticed that our images are being rotated in sherlock. It seems that this is happening in gothumb (we have the original in the correct orientation) Rather than try and work this out I found this issue. DAddYE/vips#37 What is concerning is that from the README > When generating JPEG output all metadata is removed and Huffman tables optimised without having to use separate command line tools like jpegoptim and jpegtran. I'm guessing at Go a bit so there's likely some unwanted changes in this :(
openskydoor
force-pushed
the
move-away-from-vips
branch
from
a2a9c7e to
5fcae4c
Compare
openskydoor
force-pushed
the
move-away-from-vips
branch
from
5fcae4c to
67d6176
Compare
and clean up
openskydoor
force-pushed
the
move-away-from-vips
branch
from
b0886fb to
02fc2ee
Compare
openskydoor
pushed a commit
that referenced
this pull request
Oct 8, 2017
Move away from VIPS for bimg
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that our images are being rotated in one of our apps.
It seems that this is happening in gothumb (we have the original in the correct orientation)
Rather than try and work this out I found this issue. DAddYE/vips#37
What is concerning is that from the README
I'm guessing at Go a bit so there's likely some unwanted changes in this :(