Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and tests #11

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Update readme and tests #11

merged 11 commits into from
Oct 31, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Oct 18, 2024

I think my next step would be to add a schema.

If we may be assembling these structures by hand, it's nice to have early feedback that we're missing something, rather than an error from deeper in the code... but if the structure is particularly complex, maintaining it might not be worth the effort. Thoughts?

@mccalluc mccalluc requested a review from Shoeboxam October 18, 2024 16:10
@mccalluc mccalluc marked this pull request as ready for review October 18, 2024 16:11
This was referenced Oct 18, 2024
Copy link
Member

@Shoeboxam Shoeboxam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like a good update.

@mccalluc mccalluc merged commit dfca483 into main Oct 31, 2024
4 checks passed
@mccalluc mccalluc deleted the 1-readme-doctest branch October 31, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants