chore(push_script): refactor makefile and push scirpt #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
sonasingh46
changed the title
sonasingh46
changed the title
sonasingh46
force-pushed
the
pushscript_patch
branch
3 times, most recently
from
7776b13 to
b8b739e
Compare
sonasingh46
changed the title
sonasingh46
force-pushed
the
pushscript_patch
branch
from
b8b739e to
36f4404
Compare
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
sonasingh46
force-pushed
the
pushscript_patch
branch
from
36f4404 to
63fc247
Compare
kmova
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following :
The container images should be pushed without a
vin the tag SEMVER.The refactors script to trims the leading
vbefore pushingChange the env variable
HUB_USERtoIMAGE_ORGfor consistency across openebs repos.This variable holds the image repository user name.
Modifies the Dockerfiles to add the required labels.
Signed-off-by: Ashutosh Kumar ashutosh.kumar@mayadata.io