refact(upgrade): add volumes and mountpaths for cstor pools and volumes #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mittachaitu
requested review from
mittachaitu,
vishnuitta and
prateekpandey14
vishnuitta
reviewed
Jan 10, 2020
mittachaitu
reviewed
Jan 10, 2020
vishnuitta
reviewed
Jan 10, 2020
For now, I think we need to have if clauses in the template. Go templating provides support for if condition.
Patching the exec part each time as it is a fix in command and remains constant and is not configurable. So patching every time is safer. |
vishnuitta
reviewed
Jan 29, 2020
| ] | ||
| }, | ||
| { | ||
| "name": "maya-exporter", |
There was a problem hiding this comment.
why to mount volumes in exporter container?
shubham14bajpai
changed the title
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
shubham14bajpai
changed the title
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
vishnuitta
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham shubham.bajpai@mayadata.io
What this PR does / why we need it:
This PR adds support for new volumeMounts and volumes added in cstor pool and volume deployments. Refer #1583 #1599 #1601
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag