Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backup, cstor): fetching correct snap name in case of base backup failure #1622

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

mynktl
Copy link
Contributor

@mynktl mynktl commented Mar 2, 2020

This change fix the logic to fetch the last snapshot name from cstorcompletedbackups.openebs.io for scheduled backup. If first backup for schedule fails then last snapshot name for next backup, for the same schedule, should be empty.

fixes openebs/openebs#2926

mayank added 2 commits March 2, 2020 04:55
…pletedbackups in case of base backup failure

Signed-off-by: mayank <mayank.patel@mayadata.io>
Signed-off-by: mayank <mayank.patel@mayadata.io>
Copy link
Contributor

@moteesh moteesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnuitta vishnuitta merged commit 3c21a6b into openebs-archive:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore from scheduled backups fails if base backup doesn't have snapshot
3 participants