Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localpv-hostpath):pv deletion caused panic, if node not found #1662

Merged
merged 3 commits into from
Apr 10, 2020
Merged

fix(localpv-hostpath):pv deletion caused panic, if node not found #1662

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc237b8
fix(localpv-hostpath):pv deletion caused panic, if node not found
kmova Apr 10, 2020
35f519c
fix(localpv-hostpath): gofmt issue on provisioner_hostpath.go
kmova Apr 10, 2020
6a98dda
fix(localpv-hostpath): remove redundant nil check in provisioner_host…
kmova Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmd/provisioner-localpv/app/provisioner_hostpath.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,12 @@ func (p *Provisioner) GetNodeObjectFromHostName(hostName string) (*v1.Node, erro
Limit: 1,
}
nodeList, err := p.kubeClient.CoreV1().Nodes().List(listOptions)
if err != nil {
return nil, errors.Errorf("Unable to get the Node with the NodeHostName")
if err != nil || len(nodeList.Items) == 0 {
// After the PV is created and node affinity is set
// based on kubernetes.io/hostname label, either:
// - hostname label changed on the node or
// - the node is deleted from the cluster.
return nil, errors.Errorf("Unable to get the Node with the NodeHostName [%s]", hostName)
}
return &nodeList.Items[0], nil

Expand Down