refact(exporter): handle concurrent scrape requests #1698
Merged
+61
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where it handles the concurrent http requests and rejects it if a request is already in progress. Additionally it adds a new metrics "openebs_target_reject_request_counter" to increase the count of rejected requests, which can be helpful in debugging. Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>
utkarshmani1997
added
refactor
type: Monitoring
pr/release-note
Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>
mynktl
reviewed
May 19, 2020
|
Are we targeting this PR for 1.11? |
yes |
Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>
kmova
reviewed
May 21, 2020
kmova
reviewed
May 21, 2020
kmova
reviewed
May 21, 2020
kmova
reviewed
May 21, 2020
kmova
reviewed
May 21, 2020
utkarshmani1997
changed the title
Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>
kmova
reviewed
May 22, 2020
Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>
kmova
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Utkarsh Mani Tripathi utkarsh.tripathi@mayadata.io
Why is this PR required? What issue does it fix?:
This commit fixes an issue where it handles the concurrent http
requests and rejects it if a request is already in progress.
What this PR does?:
It adds a new metrics "openebs_target_reject_request_counter" to increase the count
of rejected requests, which can be helpful in debugging and improves mutex locking.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
the exporter, it will only process 1 request at a time and rest other requests will be rejected and new metrics openebs_target_reject_request_counter will be incremented.
Any additional information for your reviewer? :
No
Checklist:
<type>(<scope>): <subject>