fix(usage): add nil checks to avoid panic #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmova
added
pr/hold-merge
| @@ -85,7 +85,10 @@ func (s *HTTPServer) volumeV1alpha1SpecificRequest(resp http.ResponseWriter, req | |||
| switch req.Method { | |||
| case "POST": | |||
| cvol, err := volOp.create() | |||
| pvc := cvol.ObjectMeta.Labels["openebs.io/persistent-volume-claim"] | |||
| pvc := "" | |||
There was a problem hiding this comment.
rename to pvcName ?
Once a PVC create request is processed by the CAST, the response is inspected to fetch the PVC name and other details to generate an analytics log. This was done as part of the PR: #1708 This commit adds a nil check to handle the case of error response to avoid a panic. Signed-off-by: kmova <kiran.mova@mayadata.io>
Signed-off-by: kmova <kiran.mova@mayadata.io>
Signed-off-by: kmova <kiran.mova@mayadata.io>
kmova
added a commit
that referenced
this pull request
Jul 1, 2020
Once a PVC create request is processed by the CAST, the response is inspected to fetch the PVC name and other details to generate an analytics log. This was done as part of the PR: #1708 This commit adds a nil check to handle the case of an error response to avoid a panic. Signed-off-by: kmova <kiran.mova@mayadata.io> (cherry picked from commit d70090d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kmova kiran.mova@mayadata.io
Why is this PR required? What issue does it fix?:
openebs/openebs#3064
What this PR does?:
Adds nil checks to catch provisioning errors.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Verified by creating a PVC with name > 63 chars long. The output shows the following error when
kubectl describe pvcis executed.Verified by creating a PVC with name < 63 chars long. Volume gets created successfully.
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>