Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add affinity to the ndm-operator deployment #699

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nearora-msft
Copy link

Pull Request template

Why is this PR required? What issue does it fix?:
This PR allows the user of the helm chart to set affinity to the ndm-operator pods.

What this PR does?:

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING

The PR title message must follow convention:
<type>(<scope>): <subject>.

Where:
Most common types are:
* feat - for new features, not a new feature for build script
* fix - for bug fixes or improvements, not a fix for build script
* chore - changes not related to production code
* docs - changes related to documentation
* style - formatting, missing semi colons, linting fix etc; no significant production code changes
* test - adding missing tests, refactoring tests; no production code change
* refactor - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes
* cherry-pick - if PR is merged in develop branch and raised to release branch(like v0.4.x)

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@niladrih
Copy link
Member

niladrih commented Oct 4, 2023

@nearora-msft -- Thank you for this helm chart enhancement. We release a new chart for each new change, and as such need a version bump on the chart 'version'. Your PR needs a change in the https://github.com/openebs/node-disk-manager/blob/develop/deploy/helm/charts/Chart.yaml file, 'version' field. You'd have to bump the version to 2.1.1. The appVersion need not change, as there is no code change.

Also you'd have to sign your commit. We need our DCO!
I'll try to summarise the steps, but feel free to google this :P:

  • Check if you name and email is set on your git config
     get config --get user.email
  • If it's not set, set them using git config user.name "<your-name>", git config user.main "<your-email>
  • Sign your commit:
git commit --amend -s --no-edit

Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a chart version bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants