-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alpine-sh and alpine-bash container images #36
Conversation
tiagolobocastro
commented
Jul 1, 2024
•
edited
Loading
edited
@Abhinandan-Purkait @niladrih comments on the names please :D |
8aeac34
to
b883df3
Compare
IMO, the names shouldn't be tied to their purpose on the kubernetes' 'machine', i.e. as initContainers. It should be tied to the key libs, packages it contains. Here we don't have an entrypoint, or cmd, so we can't tie the name to that.
Do we need the init-sh container? Should the bash one be enough for our use-cases at the moment? It adds another container to our helm chart and it saves very little space after we optimise it down. |
hmm I'm not sure, calling it simply by the names of the packages feels somewhat incomplete.
The init-sh container is very simple to add since we adding the bash one, there's no cost of adding it so seemed a no brainer. |
I am okay with it. What about |
I guess so, though again we'd be adding purpose to the name :) |
b883df3
to
77e6f68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'll require the image repositories to be created. I can take it up for docker.io, need a hand with quay. I'll try to see if my GitHub auth lets me work on ghcr.
77e6f68
to
37ffbf9
Compare
Support for multiple images (dockerfiles) during the make process Ensures make test does not leave exited containers Add make clean to delete buildx builder Removes the push scripts as those are no longer used Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Adds alpine-sh and alpine-bash which are minimalist images These can be useful for small init containers Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
37ffbf9
to
8b881ce
Compare
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>