Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enhance pull_request workflow #324

Merged
merged 1 commit into from
Aug 2, 2024
Merged

ci: enhance pull_request workflow #324

merged 1 commit into from
Aug 2, 2024

Conversation

dsharma-dc
Copy link
Contributor

Workflow in detail

  1. A user creates a PR to develop or release/x.y branch.
  2. The concerned GitHub action workflow kicks in on the PR.
  3. First, it checks out and sets up the runner.
  4. It then runs the lint. Shellcheck and helm lint.
  5. Verify the chart version, it should be of the format x.y+1.0-develop. If it’s anything else, the workflow fails. From now on any change to the helm chart in the PR would not need a helm version change. Users are not supposed to change the chart version in their PRs, even if it’s a helm change.
  6. Extract the chart version from the chart. This tag would be used for building the image locally.
  7. Build the images using the code in the branch and tag it with x.y+1.0-develop
  8. Set up the minikube cluster.
  9. Execute the CI tests by installing the helm chart from the deploy/helm/charts directory. Set the image pull policy to Never since we are supposed to use the images built in the previous step.
  10. Execute the CI tests. We are to use the helm chart here.
  11. If the test passes the CI succeeds else it fails.

Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc
Copy link
Contributor Author

Any more reviews on this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants