feat(chores): Add missing tools to nix-shell

[mhkarimi1383]

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?: controller-tools and some other tools are missing from nix-shell

What this PR does?: adds corresponding packages

Does this PR require any upgrade changes?: No

If the changes in this PR are manually verified, list down the scenarios covered::

just run nix-shell

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

• Fixes #
• PR Title follows the convention of <type>(<scope>): <subject>
• Has the change log section been updated?
• Commit has unit tests
• Commit has integration tests
• (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
• (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (8feeaa0) to head (0313fa2).
Report is 39 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
- Coverage    98.66%   97.22%   -1.44%     
===========================================
  Files            2        2              
  Lines          673      902     +229     
===========================================
+ Hits           664      877     +213     
- Misses           5       18      +13     
- Partials         4        7       +3     

Flag	Coverage Δ
bddtests	97.22% <ø> (-1.44%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mhkarimi1383]

I also want to add .envrc to automatically load that

[tiagolobocastro]

Pardon my ignorance, what's in kubernetes-controller-tools ?

[mhkarimi1383]

@tiagolobocastro
controller-gen cli

[dsharma-dc]

Though nothing harmful, do we really need this in product nix shell ? The required controller-gen is currently installed from the Makefile in the repo and is used to generate manifests.

[mhkarimi1383]

In my NixOS I ran make -j 1 and controller-gen not found and with the latest one from nix repos (unstable) I got unrecognized option error for controller-gen command

[tiagolobocastro]

Though nothing harmful, do we really need this in product nix shell ? The required controller-gen is currently installed from the Makefile in the repo and is used to generate manifests.

Downloaded binaries are not likely to work on nix and NixOS, may require patching et all.
It's simpler to just put it on the nix-shell rather than figure out why it doesn't work.

[mhkarimi1383]

I made this PR draft since I see that some more tools are missing....

I want to add every required tools to shell.nix to make easier to work for NixOS users :)

[mhkarimi1383]

Commit notes/descriptions are important

[mhkarimi1383]

Also we can change all of the actions to use nix shell, so changing go version, etc., will be easier

[tiagolobocastro]

Sounds good, just let us know when this is working and ready to merge 👍

[mhkarimi1383]

@tiagolobocastro
Looks like ready, But since I'm getting #353 error I can't be sure about that

[mhkarimi1383]

Almost complete,
I have isolated nix-shell's gopath and tempdir, Since installing specific version of some packages is a bit messy