Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(new cStor deployments): add OpenEBS base directory in new CStor deployments #1599

Merged
merged 2 commits into from
Feb 1, 2020
Merged

fix(new cStor deployments): add OpenEBS base directory in new CStor deployments #1599

merged 2 commits into from
Feb 1, 2020

Conversation

mittachaitu
Copy link

Signed-off-by: mittachaitu sai.chaithanya@mayadata.io

What this PR does / why we need it:
This PR is a continuation of PR: #1583 and new deployments strictly follow to store component related files in one path of the host machine and that path called OPENEBS_IO_BASE_DIR.
How Users Can Configure:
If users need to configure base directory he has to set on OPENEBS_IO_BASE_DIR Env in cspc-operator & CVC-operator.

What files stored in the host machine:

  • When CSPC is deployed pool pod will generate lock file, sock file, core files, and pool cache file inside the container and the container path is mounted on BASE_DIR/cstor-pool/<cspc_name> host path.
  • When cStor volume is deployed target pod will store core files inside the container and the container path is mounted on BASE_DIR/cstor-target/<volume_name> host path.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist:

  • Fixes #
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

fix(mountpath): fix CStor pools and CStor target pod mount paths
857520e 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
vishnuitta
vishnuitta reviewed Jan 31, 2020
View reviewed changes
cmd/cspc-operator/app/storagepool_create.go
@@ -174,7 +179,7 @@ func (pc *PoolConfig) GetPoolDeploySpec(cspi *apis.CStorPoolInstance) (*appsv1.D
volume.NewBuilder().
WithName("tmp").
WithHostPathAndType(
getSparseDirPath()+"/shared-"+pc.AlgorithmConfig.CSPC.Name,
env.GetOpenebsBaseDirPath()+"/cstor-pool/"+pc.AlgorithmConfig.CSPC.Name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration from SPC to CSPC need to be taken care due to this cc: @shubham14bajpai

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @vishnuitta. Just one small question, are we going to ask users to come to the latest version of SPC before migration? If yes then upgrade will take care of this automatically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.. we should do migration from latest openebs version

vishnuitta
vishnuitta reviewed Jan 31, 2020
View reviewed changes
Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove '-target' from this line of path: {{ .Config.TargetDir.value }}/shared-{{ .Volume.owner }}-target from CAS templates?

@vishnuitta
Copy link
Contributor

should we remove '-target' from this line of path: {{ .Config.TargetDir.value }}/shared-{{ .Volume.owner }}-target from CAS templates?

not from above line.. but, the one in storagepath

@mittachaitu
Copy link
Author

mittachaitu commented Jan 31, 2020 •
edited
Loading

should we remove '-target' from this line of path: {{ .Config.TargetDir.value }}/shared-{{ .Volume.owner }}-target from CAS templates?

Done

@mittachaitu mittachaitu reopened this Jan 31, 2020
This commit incorporates review comments
59916ad 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
vishnuitta
vishnuitta approved these changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

@vishnuitta vishnuitta merged commit 61e106c into openebs-archive:master Feb 1, 2020
@shubham14bajpai shubham14bajpai mentioned this pull request Feb 3, 2020
Merged
9 tasks
@kmova kmova added this to the 1.7.0 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham14bajpai shubham14bajpai shubham14bajpai left review comments

@vishnuitta vishnuitta vishnuitta approved these changes

@prateekpandey14 prateekpandey14 Awaiting requested review from prateekpandey14

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mittachaitu @vishnuitta @shubham14bajpai @kmova