feat(usage): include pvc name in volume events #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the usage analytics collected, it is hard to know why a particular type of storage engine is used over other. As the PVC names typically correspond to the application, this commit helps in adding PVC name to the volume events. The PVC name will be set as CampaignName property in analytics. Signed-off-by: kmova <kiran.mova@mayadata.io>
Signed-off-by: kmova <kiran.mova@mayadata.io>
vharsh
reviewed
Jun 3, 2020
vharsh
approved these changes
Jun 3, 2020
kmova
added a commit
that referenced
this pull request
Jul 1, 2020
Once a PVC create request is processed by the CAST, the response is inspected to fetch the PVC name and other details to generate an analytics log. This was done as part of the PR: #1708 This commit adds a nil check to handle the case of an error response to avoid a panic. Signed-off-by: kmova <kiran.mova@mayadata.io>
kmova
added a commit
that referenced
this pull request
Jul 1, 2020
Once a PVC create request is processed by the CAST, the response is inspected to fetch the PVC name and other details to generate an analytics log. This was done as part of the PR: #1708 This commit adds a nil check to handle the case of an error response to avoid a panic. Signed-off-by: kmova <kiran.mova@mayadata.io> (cherry picked from commit d70090d)
kmova
added a commit
to openebs/dynamic-localpv-provisioner
that referenced
this pull request
Nov 1, 2020
Once a PVC create request is processed by the CAST, the response is inspected to fetch the PVC name and other details to generate an analytics log. This was done as part of the PR: openebs-archive/maya#1708 This commit adds a nil check to handle the case of an error response to avoid a panic. Signed-off-by: kmova <kiran.mova@mayadata.io>
niladrih
pushed a commit
to openebs/dynamic-localpv-provisioner
that referenced
this pull request
Jun 28, 2024
Once a PVC create request is processed by the CAST, the response is inspected to fetch the PVC name and other details to generate an analytics log. This was done as part of the PR: openebs-archive/maya#1708 This commit adds a nil check to handle the case of an error response to avoid a panic. Signed-off-by: kmova <kiran.mova@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
From the usage analytics collected, it is hard
to know why a particular type of storage engine
is used over other.
What this PR does?:
As the PVC names typically correspond to the
application, this commit helps in adding PVC name
to the volume events.
The PVC name will be set as CampaignName property
in analytics.
Does this PR require any upgrade changes?:
Not applicable
If the changes in this PR are manually verified, list down the scenarios covered::
Verified by creating cstor, jiva and Local PV volumes. The PVC name was sent as part of the campaign.
Any additional information for your reviewer? :
The changes done in this PR needs to be made for ZFS Local PV and CSI volumes as well.
Checklist:
<type>(<scope>): <subject>Signed-off-by: kmova kiran.mova@mayadata.io