feat(spc): add capability to specify allowed BD tags on SPC #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds capability to specify allowed BD tags on SPC via annotations. The annotation key is `cstor.openebs.io/allowed-bd-tags` and allowed value is comma separated strings. For example "fast,slow" is a possible value and in this case SPC provisioner will reject BDs that have a BD tag (`openebs.io/block-device-tag`) present on it and the value is other than fast or slow. Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
akhilerm
reviewed
Sep 7, 2020
akhilerm
reviewed
Sep 7, 2020
akhilerm
approved these changes
Sep 7, 2020
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
mittachaitu
approved these changes
Sep 8, 2020
| @@ -809,3 +809,295 @@ func TestFilterNonReleasedDevices(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestBDTagFilter(t *testing.T) { | |||
There was a problem hiding this comment.
Nice UT... I like the tag names:+1:
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
mittachaitu
approved these changes
Sep 8, 2020
sonasingh46
added
the
pr/ready-to-merge
mittachaitu
pushed a commit
to mittachaitu/maya
that referenced
this pull request
Sep 11, 2020
…archive#1748) * feat(spc): add capability to specify allowed BD tags on SPC This commit adds the capability to specify allowed BD tags on SPC via annotations. The annotation key is `openebs.io/allowed-bd-tags` and the allowed value is comma separated strings. For example: "fast,slow" is a possible value and in this case SPC provisioner will reject BDs that have a BD tag (`openebs.io/block-device-tag`) present on it and the value is other than fast or slow. Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
7 tasks
prateekpandey14
pushed a commit
that referenced
this pull request
Sep 11, 2020
* feat(spc): add capability to specify allowed BD tags on SPC This commit adds the capability to specify allowed BD tags on SPC via annotations. The annotation key is `openebs.io/allowed-bd-tags` and the allowed value is comma separated strings. For example: "fast,slow" is a possible value and in this case SPC provisioner will reject BDs that have a BD tag (`openebs.io/block-device-tag`) present on it and the value is other than fast or slow. Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the capability to specify allowed BD tags on SPC via
annotations.
The annotation key is
cstor.openebs.io/allowed-bd-tagsand the allowed valueis comma-separated strings.
For example "fast,slow" is a possible value, and in this case SPC provisioner
will reject BDs that have a BD tag (
openebs.io/block-device-tag) present onit and the value is other than fast or slow.
Signed-off-by: Ashutosh Kumar ashutosh.kumar@mayadata.io