fix(filter): add block-device-tag filter during manual claiming
#404
Conversation
|
|
|
Re-opening as it came up with #430 |
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 40.53% 40.37% -0.16%
==========================================
Files 71 72 +1
Lines 3488 3529 +41
==========================================
+ Hits 1414 1425 +11
- Misses 1966 1995 +29
- Partials 108 109 +1
Continue to review full report at Codecov.
|
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
|
@akhilerm -- can you update with change log please. |
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
|
Done @kmova |
|
The changes in this PR look good. This change will help with avoiding cases where BD reserved to be used by Local PV is not claimed by SPC. However, merging this might break some high-level automation scripts around cStor pool creation. cStor Pool creation (SPC and CSPC) is adding a new feature to take as input "allowed-block-device-tags", so the BDs should be configed to the white-listed BD tags for a given SPC or CSPC. This PR will be merge once the above changes are implemented. ( cc: @sonasingh46 ) |
…enebs-archive#404) Enforce check on block device tag even for cases where block devices are claimed with block device name. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Enforce check on block device tag even for cases where block devices are claimed with block device name. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io